Skip to content

ACM 22860#3

Open
mshort55 wants to merge 5 commits intomainfrom
ACM-22860
Open

ACM 22860#3
mshort55 wants to merge 5 commits intomainfrom
ACM-22860

Conversation

@mshort55
Copy link
Owner

  • ACM-22860 - RBAC UI Implementation - Roles - Permissions - built skeleton page and mock data
  • Implemented realistic mock data, added column id, added bold style for verbs
  • Changed to use existing interfaces, minor variable names and verbage changes
  • Added resource abbreviations with labels, fixed pagination, changed minor verbiage
  • Fixed search and sort

📝 Summary

Ticket Summary (Title):

Ticket Link:

Type of Change:

  • 🐞 Bug Fix
  • ✨ Feature
  • 🔧 Refactor
  • 💸 Tech Debt
  • 🧪 Test-related
  • 📄 Docs

✅ Checklist

General

  • PR title follows the convention (e.g. ACM-12340 Fix bug with...)
  • Code builds and runs locally without errors
  • No console logs, commented-out code, or unnecessary files
  • All commits are meaningful and well-labeled
  • All new display strings are externalized for localization (English only)
  • (Nice to have) JSDoc comments added for new functions and interfaces

If Feature

  • UI/UX reviewed (if applicable)
  • All acceptance criteria met
  • Unit test coverage added or updated
  • Relevant documentation or comments included

If Bugfix

  • Root cause and fix summary are documented in the ticket (for future reference / errata)
  • Fix tested thoroughly and resolves the issue
  • Test(s) added to prevent regression

🗒️ Notes for Reviewers

…eton page and mock data

Signed-off-by: Matthew Short <mshort@redhat.com>
…r verbs

Signed-off-by: Matthew Short <mshort@redhat.com>
…changes

Signed-off-by: Matthew Short <mshort@redhat.com>
…inor verbiage

Signed-off-by: Matthew Short <mshort@redhat.com>
Signed-off-by: Matthew Short <mshort@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant